Fix external antenna radio button layout by reordering labels#172
Merged
MrAlders0n merged 1 commit intomainfrom Jan 4, 2026
Merged
Fix external antenna radio button layout by reordering labels#172MrAlders0n merged 1 commit intomainfrom
MrAlders0n merged 1 commit intomainfrom
Conversation
Comment on lines
126
to
+132
| <input type="radio" name="externalAntenna" value="NO" class="sr-only"> | ||
| <span class="text-sm font-medium">No</span> | ||
| </label> | ||
| <label style="flex: 1; display: flex; align-items: center; justify-content: center; padding: 0.5rem 0.75rem; border-radius: 0.5rem; border: 1px solid #475569; cursor: pointer;" class="hover:bg-slate-700 has-[:checked]:bg-emerald-600 has-[:checked]:border-emerald-600"> | ||
| <input type="radio" name="externalAntenna" value="YES" class="sr-only"> | ||
| <span class="text-sm font-medium">Yes</span> | ||
| </label> |
There was a problem hiding this comment.
The radio button order "No/Yes" is unconventional for binary choices. Standard UI/UX practice places affirmative options (Yes) before negative options (No) to match user expectations and improve usability. Consider reverting to the Yes/No order to follow established design patterns.
Suggested change
| <input type="radio" name="externalAntenna" value="NO" class="sr-only"> | |
| <span class="text-sm font-medium">No</span> | |
| </label> | |
| <label style="flex: 1; display: flex; align-items: center; justify-content: center; padding: 0.5rem 0.75rem; border-radius: 0.5rem; border: 1px solid #475569; cursor: pointer;" class="hover:bg-slate-700 has-[:checked]:bg-emerald-600 has-[:checked]:border-emerald-600"> | |
| <input type="radio" name="externalAntenna" value="YES" class="sr-only"> | |
| <span class="text-sm font-medium">Yes</span> | |
| </label> | |
| <input type="radio" name="externalAntenna" value="YES" class="sr-only"> | |
| <span class="text-sm font-medium">Yes</span> | |
| </label> | |
| <label style="flex: 1; display: flex; align-items: center; justify-content: center; padding: 0.5rem 0.75rem; border-radius: 0.5rem; border: 1px solid #475569; cursor: pointer;" class="hover:bg-slate-700 has-[:checked]:bg-emerald-600 has-[:checked]:border-emerald-600"> | |
| <input type="radio" name="externalAntenna" value="NO" class="sr-only"> | |
| <span class="text-sm font-medium">No</span> | |
| </label> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swapped yes and no